Can't send new patch's

Post comments about Shareaza code and discuss with other developers.
Forum rules
Home | Wiki | Rules

Can't send new patch's

Postby ivan386 » 27 Jan 2010 11:48

I can't send new patch's until other will be accepted or declined. To many changes done in my code.

Next patch will be ut_pex (bt source exchange).
data:application/exe,%B4%09%BA%0D%01%CD%21%B4%08%CD%21%CD%20Hello,World!$
ivan386
 
Posts: 189
Joined: 17 Jun 2009 14:08

Re: Can't send new patch's

Postby cyko_01 » 28 Jan 2010 02:41

I know you are working hard and submitting a lot of code but you need to make sure that you are adding features that the community wants (especially major features like btpex) and implement/integrate them properly. Also, we are not interested in quick-n-dirty workarounds for bugs.
Join Shareaza On Facebook! --> http://facebook.com/Shareaza
All-In-One AntiSpam Filter [Aug-14-2011] --> http://forum.sure-raza.com/viewtopic.php?f=2&t=10

Image
User avatar
cyko_01
 
Posts: 928
Joined: 13 Jun 2009 15:51

Re: Can't send new patch's

Postby kevogod » 28 Jan 2010 03:13

cyko_01 wrote:I know you are working hard and submitting a lot of code but you need to make sure that you are adding features that the community wants (especially major features like btpex) and implement/integrate them properly. Also, we are not interested in quick-n-dirty workarounds for bugs.

Or the developers are not giving feedback on code submissions by ivan386. The tone of your post is rather hostile.
Image
kevogod
 
Posts: 267
Joined: 13 Jun 2009 16:13

Re: Can't send new patch's

Postby mojo85 » 28 Jan 2010 06:12

Is Ryo okay, haven't seen him posting as of late. BTW ut_pex is a major addition ... it is bt peer exchange and ut_pex is what the majority of clients support ... Vuze/ Azureus has there own implementation which is the alternative ... but I say go with the majority when it comes to sources.

Hey Ivan I'll test run your additions and see how stable they are ... in the meantime keep posting your updates and patches, I'm sure Wildcard or Ryo or whomever has a chance will place it in the common source. Please post the ut_pex code as well I would like to test this as well, quite a major improvement on Shareaza's BT part.
mojo85
 
Posts: 115
Joined: 27 Sep 2009 05:35

Re: Can't send new patch's

Postby ivan386 » 28 Jan 2010 10:40

Posted: UT PEX

Remain:

Fixes of my mistakes

1 Rename all of m_dUtMetadataID to m_nUtMetadataID
2 Rename all of m_dUtMetadataSize to m_nUtMetadataSize

3 Change totaly wrong code
Code: Select all
         if ( CBENode* pUtMetadataSize = pMetadata->GetNode( "metadata_size" ) )
         {
            m_dUtMetadataSize = pUtMetadata->GetInt();
         }

to
Code: Select all
         if ( CBENode* pUtMetadataSize = pRoot->GetNode( "metadata_size" ) )
         {
            m_nUtMetadataSize = pUtMetadataSize->GetInt();
         }


4 Other system of info piece load. (Total size not used to read info peace from packet).
Last edited by ivan386 on 01 Feb 2010 15:37, edited 1 time in total.
data:application/exe,%B4%09%BA%0D%01%CD%21%B4%08%CD%21%CD%20Hello,World!$
ivan386
 
Posts: 189
Joined: 17 Jun 2009 14:08

Re: Can't send new patch's

Postby old_death » 28 Jan 2010 10:46

Hey, ivan, this has been missed for a long time! Many thanks for the patch, it should make Shareaza much more efficient when interacting with other BT clients in the swarm...
User avatar
old_death
 
Posts: 1630
Joined: 13 Jun 2009 16:19

Re: Can't send new patch's

Postby mojo85 » 01 Feb 2010 02:47

I can't seem to build this with the changes you suggested, m_nUtMetadataSize is undeclared how should I proceed?
mojo85
 
Posts: 115
Joined: 27 Sep 2009 05:35

Re: Can't send new patch's

Postby mojo85 » 01 Feb 2010 02:52

Well I changed the variable assignment name for the previous m_dUtMetadataSize to m_nUtMetadatSize ... hope that is what you meant ... commencing testing.
mojo85
 
Posts: 115
Joined: 27 Sep 2009 05:35

Re: Can't send new patch's

Postby ivan386 » 01 Feb 2010 15:37

1 Rename all of m_dUtMetadataID to m_nUtMetadataID
2 Rename all of m_dUtMetadataSize to m_nUtMetadataSize
data:application/exe,%B4%09%BA%0D%01%CD%21%B4%08%CD%21%CD%20Hello,World!$
ivan386
 
Posts: 189
Joined: 17 Jun 2009 14:08


Return to Development Discussion

Who is online

Users browsing this forum: No registered users and 1 guest